-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to manifest v3 #1396
Merged
Merged
Migrate to manifest v3 #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async _receiveEvent(data, sendResponse) { | ||
const {type, params} = data | ||
console.log('Message received', data) | ||
const result = await this[type](...params) |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call High
Invocation of method with name may dispatch to unexpected target and cause an exception.
user-controlled
Error loading related location
Loading it doesn't work anymore with manifest v3
marcelklehr
force-pushed
the
enh/manifest-v3
branch
from
July 19, 2023 16:17
debf84d
to
44648db
Compare
marcelklehr
force-pushed
the
enh/manifest-v3
branch
from
July 23, 2023 14:30
007d9ff
to
fa8ff01
Compare
marcelklehr
force-pushed
the
enh/manifest-v3
branch
2 times, most recently
from
August 2, 2023 13:07
e6f20d8
to
a385a22
Compare
marcelklehr
force-pushed
the
enh/manifest-v3
branch
from
August 2, 2023 13:21
a385a22
to
a8221bf
Compare
…to function in service worker
marcelklehr
force-pushed
the
enh/manifest-v3
branch
from
August 25, 2023 15:08
15ceb61
to
995a53b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.